fix(arrow/scalar): allow null extension scalars to keep null storage - #1000
Merged
zeroshade merged 3 commits intoJul 27, 2026
Merged
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
fallintoplace
changed the title
zeroshade
approved these changes
Jul 27, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Verified: `MakeNullScalar` on an extension type produces `Valid=false` with a non-nil (but null) storage scalar, and the old `Extension.Validate` rejected any non-nil storage when invalid — so the factory produced a scalar that failed its own validation. I reproduced the "null extension_type<storage=int16> scalar has storage value" error on `main`. The fix correctly permits null storage while still rejecting non-null storage. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeNullScalarrepresents a null extension scalar with a null storage scalar.Extension.Validaterejected that factory-created shape even though it is the natural null representation.This allows validated null storage for null extension scalars, still rejects non-null storage, and adds regression coverage for both cases.
Tests:
go test ./arrow/scalar